Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@abduznik
Copy link

After reviewing the code, I noticed that ModAutoPlay is a class that I can check against.

Using this option, I have strictly made sure that when the user presses CTRL + Enter, it runs the ModAutoPlay without adding "artifacts" of unranked and mods. This also works the other way around; if the user added mods or is in unranked mode, it will appear accordingly when the user presses CTRL + Enter.

Thank you and always welcoming feedback! Fixes #35973

@monochrome22
Copy link

monochrome22 commented Dec 15, 2025

Correct me if I'm wrong, but isn't the proper solution to #35973 redesigning the button as proposed in #33314? There would be no overlap if the button was redesigned to not expand.

@abduznik
Copy link
Author

Correct me if I'm wrong, but isn't the proper solution to #35973 redesigning the button as proposed in #33314? There would be no overlap if the button was redesigned to not expand.

Hi!
I agree with you on this approach, I'm still quite new however my previous pull request to this problem was to just remove the mods tab expansion feature as a whole you can see it at pull #35986
I didn't however suggest a whole redesign but to just remove the expanding feature.

@bdach
Copy link
Collaborator

bdach commented Dec 16, 2025

Screen.Recording.2025-12-16.at.08.11.15.mov

Having autoplay alone not show the display bar, but autoplay in conjunction with another mod show the bar is too broken to live.

@bdach bdach closed this Dec 16, 2025
@abduznik
Copy link
Author

Understood, thank you! I will see what I can do to fix this.
Didn't notice it would conjure this way.

Screen.Recording.2025-12-16.at.08.11.15.mov

Having autoplay alone not show the display bar, but autoplay in conjunction with another mod show the bar is too broken to live.

@abduznik
Copy link
Author

abduznik commented Dec 18, 2025

Screen.Recording.2025-12-16.at.08.11.15.mov
Having autoplay alone not show the display bar, but autoplay in conjunction with another mod show the bar is too broken to live.

Hello, if (!Current.Value.Any(m => m is not ModAutoplay)) is truly the wrong way. I was thinking of changing it to m.UserPlayable instead and it seems it can go well with only the unranked option, and with the mods display tab it can remain the same.

8mb.video-u8c-ME046JUF.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Ctrl+Enter in song select causes a broken animation in the footer

3 participants