Prevent mod track adjustments from modifying BGM speed in queue #36027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Dec 16, 2025
| { | ||
| base.OnEntering(e); | ||
|
|
||
| musicController.ApplyModTrackAdjustments = false; |
Collaborator
There was a problem hiding this comment.
Rather than touching musicController directly this should be specified via
osu/osu.Game/Screens/IOsuScreen.cs
Lines 106 to 110 in 82256ae
Compare e.g.
osu/osu.Game/Screens/Edit/Editor.cs
Line 89 in 691e8bc
Contributor
Author
There was a problem hiding this comment.
Thank you for the correction, I'm just now learning about the osu! project's structure, so it's quite possible I miss trivial things like that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35865.
This fixes a bug where the background music speed during the quick play queue is affected by the mods selected in map selection. The bug was caused by the screen failing to reset the global musicController.ApplyModTrackAdjustments state. The fix explicitly sets the value to false in OnEntering and OnResuming.