-
-
Notifications
You must be signed in to change notification settings - Fork 78
Add citation guidelines, update for v2 paper, remove publications #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the Markdown linter happy.
uekerman
approved these changes
Aug 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Everything as agreed 👍
One aspect I am not sure about is if the current DOI will automatically lead or hint to the latest revision of our paper
I think so. If not, you get a very visible link "there is a newer version available" IIRC.
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Co-authored-by: Benjamin Uekermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #177:
publications.htmland the old/publications/to the literature guide.I did not remove the entries from our internal database, since they are actually useful. One can render any publication as a card in any page. In fact, I added a new entry for our v2 paper and reworked the entry for the old adapters overview article.
One aspect I am not sure about is if the current DOI will automatically lead or hint to the latest revision of our paper, as a second one is expected. In any case, we can just find & replace once that is needed.
@uekerman please have a look if this looks as agreed (and if there are any typos) and merge. Some screenshots to help the review:
Landing page:
Literature guide: