Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@davidscn
Copy link
Member

... as required by precice/precice#1550

@MakisH
Copy link
Member

MakisH commented Jan 26, 2023

I have not followed the discussion on this feature, but are we now going back from the simple <mapping:rbf ... > with automatic algorithm selection to <mapping::rbf-global-direct ...> and <<mapping:rbf-global-iterative ...>?

Have you already considered keeping the <mapping:rbf ...> with a default option?

Remember that we used to have rbf and petrbf, which was always difficult to explain.

@davidscn
Copy link
Member Author

I have not followed the discussion on this feature, but are we now going back from the simple <mapping:rbf ... > with automatic algorithm selection to <mapping::rbf-global-direct ...> and <<mapping:rbf-global-iterative ...>?

No. Did you read careful enough or do I need to be more explicit?

@MakisH
Copy link
Member

MakisH commented Jan 27, 2023

I have not followed the discussion on this feature, but are we now going back from the simple <mapping:rbf ... > with automatic algorithm selection to <mapping::rbf-global-direct ...> and <<mapping:rbf-global-iterative ...>?

No. Did you read careful enough or do I need to be more explicit?

It's complicated. I think I read it in the same speed as a user would read it, but I got confused. Part of the reason was that I had the (wrong) impression that we already had <mapping:rbf> as a tag, or that we at least discussed it at some point (it would be great to have it to auto-generate default configs).

Reading it again, the subtags are great, but this documentation entry could largely benefit from a diff code block with a concrete example. Right now, there is simply too much to follow in inline text.

@davidscn davidscn merged commit 1fe09cc into master Apr 4, 2023
@davidscn davidscn deleted the mapping-config branch April 4, 2023 09:05
@BenjaminRodenberg BenjaminRodenberg added this to the Version 3.0.0 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants