Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

IshaanDesai
Copy link
Member

Fixes error which popped up in #50 (comment)

@IshaanDesai IshaanDesai requested a review from MakisH November 22, 2022 10:24
@IshaanDesai IshaanDesai self-assigned this Nov 22, 2022
@IshaanDesai
Copy link
Member Author

@MakisH I am not sure if the install-fenics.sh script is the right place to manually uninstall fenics-ufl (to avoid the problem), but we can try this. I looked through the Vagrantfile to see which packages are installed after the fenics-adapter and it seems highly unlikely that fenics-ufl will be installed somehow later.

@IshaanDesai IshaanDesai changed the title Manually uninstall fenics-ufl package to avoid fenics not working Manually uninstall fenics-ufl package to avoid FEniCS not working Nov 22, 2022
@MakisH
Copy link
Member

MakisH commented Nov 22, 2022

I already had that before and removed it in #22, based on the discussion of #4.

Did you check if this solution works in the VM?

@IshaanDesai
Copy link
Member Author

Did you check if this solution works in the VM?

Yes I checked my downloading the box from the latest passed test on the develop branch and the solution of manually uninstalling fenics-ufl works. It was only after I confirmed this did I open this PR.

@IshaanDesai
Copy link
Member Author

Can we build the box for this branch? Then I can check if the solution works when done via the provisioning script.

@MakisH
Copy link
Member

MakisH commented Nov 22, 2022

I am merging and directly building the result. If it works, we have nothing else to fix.

@MakisH MakisH merged commit 900f746 into develop Nov 22, 2022
@MakisH MakisH deleted the fix-broken-fenics branch November 22, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants