This checkin removes un-necessary code reported by findbugs, these ch… #66

anurag-gujral · 2016-12-07T15:52:54Z

…anges have been discussed with Sanjeev

FrankGasparovic · 2016-12-16T00:33:08Z

This branch covers two stories:
US40120
US60651

anubhavi25

Looks good for the most part 👍

anubhavi25 · 2016-12-16T01:25:10Z

acs-integration-tests/src/test/java/com/ge/predix/integration/test/SubjectResourceFixture.java

+public final class SubjectResourceFixture {
+
+    private SubjectResourceFixture() {
+        //not called


best to throw an exception if construction is attempted by a method of this class:

throw new IllegalAccessError("Class is non-instantiable");

anubhavi25 · 2016-12-16T01:26:55Z

checkstyle-config/gog-sun-checks-eclipse.xml

    </module>
    <module name="EmptyStatement"/>
    <module name="EqualsHashCode"/>
-    <module name="HiddenField">


need to reach a consensus on whether or not to remove this CheckStyle rule.

FrankGasparovic · 2016-12-19T22:54:28Z

Build Success

anurag-gujral · 2016-12-20T16:32:24Z

...src/test/java/com/ge/predix/acceptance/test/policy/admin/PolicyCreationStepsDefinitions.java

 *
 * @author 212338046
 */
+//CHECKSTYLE:OFF


why checkstyle is off here is it because it is a test?

we should probably add notes everywhere "CHECKSTYLE:OFF" and "CHECKSTYLE:ON" are used mentioning why we're doing so

Checkstyle is off because these cucumber tests don't follow the naming conventions in checkstyle.

anurag-gujral · 2016-12-20T16:40:17Z

commons/src/test/java/com/ge/predix/acs/utils/HttpServletRequestUtilTest.java

        Assert.assertNull(HttpServletRequestUtil.getSubdomain(hostname, domain));
    }

+    @SuppressFBWarnings(value = "NP_NULL_PARAM_DEREF_NONVIRTUAL")


We will have to remove @SuppressFBWarnings even though it means false positive from findbugs report since our black duck scan team is disallowing findBugs annotations usage in our code. I need to talk to Jeff from black duck scan team why they are disallowing findBugs annotation until then we will have to assume that findBugs annotations are dis-allowed.

anurag-gujral · 2016-12-20T16:43:09Z

model/src/main/java/com/ge/predix/acs/rest/PolicyEvaluationRequestV1.java

    private LinkedHashSet<String> policySetsEvaluationOrder = EMPTY_POLICY_EVALUATION_ORDER;

+    public static LinkedHashSet<String> getEmptyPolicyEvaluationOrder() {
+        return EMPTY_POLICY_EVALUATION_ORDER;


we are passing access to private variable through this function, do we really want to do this?

we should remove this method since i'm removing LinkedHashSet in favor of the Set interface in another feature branch

anurag-gujral · 2016-12-20T16:45:33Z

pom.xml

            <artifactId>jackson-databind</artifactId>
            <!-- <version>${jackson.version}</version> -->
        </dependency>
+        <dependency>


black ducks scan team at GE does not want us to use findBugs as dependency please remove it.

anurag-gujral · 2016-12-20T16:46:47Z

...e/src/main/java/com/ge/predix/acs/policy/evaluation/cache/AbstractPolicyEvaluationCache.java

    }

-    abstract void delete(final String key);
+    abstract void delete(String key);


Can you please tell why are we removing the final keyword?

@anurag-gujral "final" is redundant when used for parameters in abstract method signatures (since the concrete method should add "final")

anurag-gujral · 2016-12-20T16:48:20Z

service/src/main/java/com/ge/predix/acs/privilege/management/dao/SubjectRepository.java

 public interface SubjectRepository extends JpaRepository<SubjectEntity, Long> {

-    List<SubjectEntity> findByZone(final ZoneEntity zone);
+    List<SubjectEntity> findByZone(ZoneEntity zone);


at many places we are removing final keyword, can you please explain why?

@anurag-gujral "final" is redundant when used for parameters in interface method signatures (since the concrete method should add "final")

anurag-gujral · 2016-12-20T16:49:30Z

...test/java/com/ge/predix/acs/policy/evaluation/cache/PolicyEvaluationRequestCacheKeyTest.java

    }

+    @SuppressWarnings("unused")
+    @SuppressFBWarnings(value = "DLS_DEAD_LOCAL_STORE")


Remove finbugs annotations

anubhavi25 · 2016-12-20T17:06:26Z

model/src/main/java/com/ge/predix/acs/rest/PolicyEvaluationRequestV1.java

 @ApiModel(description = "Policy evaluation request for V1.")
 public class PolicyEvaluationRequestV1 {
-    public static final LinkedHashSet<String> EMPTY_POLICY_EVALUATION_ORDER = new LinkedHashSet<String>();
+    private static final LinkedHashSet<String> EMPTY_POLICY_EVALUATION_ORDER = new LinkedHashSet<String>();


we should revert this change since i'm removing LinkedHashSet in favor of the Set interface in another feature branch

…anges have been discussed with Sanjeev

… need to be run) Signed-off-by: Anurag <[email protected]>

…nfig class

FrankGasparovic · 2016-12-20T19:41:12Z

Build success

anurag-gujral assigned anubhavi25 Dec 7, 2016

FrankGasparovic force-pushed the findBugs-fixes branch from c214399 to 24fbd9a Compare December 14, 2016 18:41

anubhavi25 reviewed Dec 16, 2016

View reviewed changes

FrankGasparovic force-pushed the findBugs-fixes branch from d5b63c9 to 6af98fd Compare December 19, 2016 21:57

FrankGasparovic assigned anurag-gujral Dec 19, 2016

FrankGasparovic force-pushed the findBugs-fixes branch from d2a3707 to 54bea11 Compare December 20, 2016 01:17

anurag-gujral commented Dec 20, 2016

View reviewed changes

anubhavi25 reviewed Dec 20, 2016

View reviewed changes

anurag-gujral and others added 10 commits December 20, 2016 10:53

This checkin removes un-necessary code reported by findbugs, these ch…

988a462

…anges have been discussed with Sanjeev

US60651: Fixed CheckStyle and FindBugs issues (WIP: integration tests…

1b1bb8d

… need to be run) Signed-off-by: Anurag <[email protected]>

US40120: Enforce check style on integration tests

04b95b9

Backout java 8 try change that find bugs reported

6bb0767

Removed cf maven plugin bump

755ae84

Added exception if user instantiates SubjectResourceFixture or TestCo…

891cf34

…nfig class

Removed cucumber changes and ignored checkstyle. Fixed hidden varaibles

6e1fe45

Added findbugs annotation dependency

29eb071

Fixed CF maven plugin version change

3d21bc5

Made changes according to Anurag's suggestions

c415ddc

FrankGasparovic force-pushed the findBugs-fixes branch from f6d0897 to c415ddc Compare December 20, 2016 18:54

FrankGasparovic merged commit bfb0663 into develop Dec 20, 2016

FrankGasparovic deleted the findBugs-fixes branch December 20, 2016 19:42

This checkin removes un-necessary code reported by findbugs, these ch… #66

This checkin removes un-necessary code reported by findbugs, these ch… #66

Uh oh!

Conversation

anurag-gujral commented Dec 7, 2016

Uh oh!

FrankGasparovic commented Dec 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anubhavi25 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrankGasparovic commented Dec 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anubhavi25 Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anubhavi25 Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrankGasparovic commented Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FrankGasparovic commented Dec 16, 2016 •

edited

Loading

anubhavi25 Dec 20, 2016 •

edited

Loading

anubhavi25 Dec 20, 2016 •

edited

Loading

FrankGasparovic commented Dec 20, 2016 •

edited

Loading