This checkin removes dependency of model and commons on hystrix libra… #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavi25
suggested changes
Dec 15, 2016
pom.xml
Outdated
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.netflix.archaius</groupId> |
Contributor
There was a problem hiding this comment.
we should remove this Hystrix-related dependency if it's not used in non-service modules (it's defined in service/pom.xml so the service code can still use it)
Contributor
Author
There was a problem hiding this comment.
This change has been addressed, thanks for noticing this.
pom.xml
Outdated
| <version>${hystrix.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.cloud</groupId> |
Contributor
There was a problem hiding this comment.
we should remove this Hystrix-related dependency if it's not used in non-service modules (it's defined in service/pom.xml so the service code can still use it). also remove the "spring-cloud-netflix-core" dependency below since it also doesn't seem to be needed.
Contributor
Author
There was a problem hiding this comment.
This change has been addressed, thanks for noticing this.
…commons as these are only required by service component of acs
… service Signed-off-by: Anurag <[email protected]>
108aba4 to
ead19e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ries