US97526: Change attribute connector persistence to JSON #100
Conversation
| boolean isCreated = false; | ||
| try { | ||
| AttributeConnector existingConnector = zoneEntity.getResourceAttributeConnector(); | ||
| isCreated = (null == existingConnector); |
There was a problem hiding this comment.
Line 29: does not look right to me, if existingConnector is not null then isCreated will be false.
There was a problem hiding this comment.
Yes, this just means that the connector has been updated. If existingConnector is null then isCreated will be true, meaning you are creating a new connector.
| public AttributeConnector retrieveResourceConnector() { | ||
| ZoneEntity zoneEntity = this.zoneResolver.getZoneEntityOrFail(); | ||
| return this.connectorConverter.toConnector(zoneEntity.getResourceAttributeConnector()); | ||
| try { |
There was a problem hiding this comment.
should we add throws clause to this function
There was a problem hiding this comment.
Guys,
This is good we are using Json thanks for fast turnaround but should we define the fields/format of the Json like:
{
"CLIENTD" : "ddd",
"CLIENDSECRET" : " secret",
"UAAURL" : "uaa_url",
"endpoint" : "ep"
}
There was a problem hiding this comment.
My understanding is that is the current format of the Json. The Object Mapper deserializes the object into those fields.
There was a problem hiding this comment.
Talked with Frank the last comment is not an issue
|
Build pass |
Signed-off-by: Irina <[email protected]>
461d41f to
e6e2917
Compare
| if (null == this.resourceAttributeConnector) { | ||
| return null; | ||
| } | ||
| return OBJECT_MAPPER.readValue(this.resourceAttributeConnector, AttributeConnector.class); |
There was a problem hiding this comment.
this method should deserialize the json only when the json has changed
- keep a separate field of type AttributeConnector
- initialize from json when getter is called, only if null
- setter should also set this field, and serialize to json only if new value does not equal current value in object
Signed-off-by: Irina [email protected]