Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DE39720: Allowed more JSON-related MIME types in the Accept request h… #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrankGasparovic merged 1 commit into from
Jul 28, 2017
Merged

DE39720: Allowed more JSON-related MIME types in the Accept request h… #145

FrankGasparovic merged 1 commit into from
Jul 28, 2017

Conversation

@anubhavi25
Copy link
Contributor

@anubhavi25 anubhavi25 commented Jul 28, 2017

…eader and added more unit tests

@anubhavi25
Copy link
Contributor Author

anubhavi25 commented Jul 28, 2017 •
edited
Loading

In this PR:

  • Allow multiple and/or non-standard Accept headers like Accept: application/json, application/*+json
  • Bumped the major version of the service to let developers know that there are backward-incompatible changes in this release (i.e. validation of Accept headers that now throw an HTTP 406 Not Acceptable)
  • Additional unit tests for some of the more exotic Accept header values, along with a test to ascertain that we return a response as usual even when no Accept header is provided (conforms to RFC 2616)

@anubhavi25
Copy link
Contributor Author

anubhavi25 commented Jul 28, 2017

Builds #796-799 passing (any failures are unrelated to this PR)

FrankGasparovic
FrankGasparovic approved these changes Jul 28, 2017
View reviewed changes
Copy link

@FrankGasparovic FrankGasparovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@FrankGasparovic FrankGasparovic merged commit 52820e5 into develop Jul 28, 2017
@FrankGasparovic FrankGasparovic deleted the DE39720 branch July 28, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FrankGasparovic FrankGasparovic FrankGasparovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FrankGasparovic FrankGasparovic

@anurag-gujral anurag-gujral

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anubhavi25 @FrankGasparovic @anurag-gujral