Changing policy does not invalidate ACS decision cache when connector is configured #149
Conversation
irinaepshteyn
left a comment
There was a problem hiding this comment.
Done reviewing. Please review my comments. Let me know if you would like me to make these changes and merge.
|
|
||
| PolicyEvaluationResult result = mockPermitResult(); | ||
| spiedCache.set(key, result); | ||
| spiedCache.get(key); |
There was a problem hiding this comment.
@FrankGasparovic, need to validate if get() correctly returned a cached result or null.
There was a problem hiding this comment.
@FrankGasparovic, also connectorsNotConfigured() test case should return:
new Object[] { null, null, DateTime.now(), false };
| private static PolicyEvaluationResult mockPermitResult() { | ||
| PolicyEvaluationResult result = new PolicyEvaluationResult(Effect.PERMIT); | ||
| result.setResolvedResourceUris(new HashSet<>(Arrays.asList(new String[] { XFILES_ID }))); | ||
| result.setResolvedResourceUris(new HashSet<>(Collections.singletonList(XFILES_ID))); |
There was a problem hiding this comment.
Use Collections.singleton(..) instead of new HashSet<>(Collections.singletonList(..))
|
|
||
| Thread.sleep(1); | ||
| this.cache.resetForSubjectsByIds(ZONE_NAME, new HashSet<>(Arrays.asList(AGENT_MULDER))); | ||
| this.cache.resetForSubjectsByIds(ZONE_NAME, new HashSet<>(Collections.singletonList(AGENT_MULDER))); |
There was a problem hiding this comment.
Use Collections.singleton(..) instead of new HashSet<>(Collections.singletonList(..))
|
|
||
| Thread.sleep(1); | ||
| this.cache.resetForResourcesByIds(ZONE_NAME, new HashSet<>(Arrays.asList(XFILES_ID))); | ||
| this.cache.resetForResourcesByIds(ZONE_NAME, new HashSet<>(Collections.singletonList(XFILES_ID))); |
There was a problem hiding this comment.
Use Collections.singleton(..) instead of new HashSet<>(Collections.singletonList(..))
779338a to
d0ca2c7
Compare
| } | ||
|
|
||
| private Object[] connectorsNotConfigured() { | ||
| AttributeConnector resourceConnector = new AttributeConnector(); |
There was a problem hiding this comment.
Remove this statement and the one below since they're unused
d0ca2c7 to
ed8a2a2
Compare
No description provided.