Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@irinaepshteyn
Copy link
Collaborator

No description provided.

Copy link
Contributor

@anubhavi25 anubhavi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes but besides that looks good 👍 merge after incorporating feedback and squashing commits

}

private String timestampValue() {
private DateTime currentDateUTC() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make static (and remove any usages of this. when calling it)

return new DateTime().withZone(DateTimeZone.UTC);
}

private String timestampUTC() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make static (and remove any usages of this. when calling it)

}
}

private DateTime timestampToDateUTC(final long timestamp) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make static (and remove any usages of this. when calling it)

return new DateTime(timestamp).withZone(DateTimeZone.UTC);
}

private DateTime timestampToDateUTC(final String timestamp) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make static (and remove any usages of this. when calling it)

Enabled attributes and decision caching for IT.
Fixed enabling decision caching from environment variable.
@irinaepshteyn irinaepshteyn merged commit 27e645d into develop Aug 31, 2017
@irinaepshteyn irinaepshteyn deleted the DE42746 branch August 31, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants