-
Notifications
You must be signed in to change notification settings - Fork 14
US161387: Refactored service POM to isolate predix profile. #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
irinaepshteyn
commented
Sep 12, 2017
- Removed duplicate plugin configurations.
- Renamed profiles to better reflect their purpose.
|
Final maven profiles and plugin configurations in service/pom.xml: public (Default)
public-titan
predix-titan
|
|
Update: After talking to @irinaepshteyn about this, if no test code uses beans conditionally wired by the Unless I'm missing something, shouldn't we change the Predix-related Maven profiles to the following?: Maven profile:
Maven profile:
Key things here are:
|
|
Also please include the story number in either the pull request title or the commit message so it's easy to track what happened from just looking at the commit history on the base branch. |
- Removed duplicate plugin configurations. - Renamed profiles to better reflect their purpose.
b5d1772 to
67905ee
Compare
|
@anubhavi25, as discussed earlier, predix spring profile is not required for ACS service unit and controller tests as it will wire predix related beans (metering, zac token service, etc.). This functionality is covered by the corresponding integration tests. However, predix maven profile is required to compile and run unit tests for audit. If you agree, please approve the pull request. |
anubhavi25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rerun the pull request pipeline since the latest rebase includes changes that were not tested (i.e. service/src/test/java/com/ge/predix/controller/test/ConfigureEnvironment.java differs from the file in the workspace of the build related to this PR: https://predix1.jenkins.build.ge.com/job/Predix-Security/job/ACS/job/ACS-PullRequest/job/acs-build-pullrequest/ws/service/src/test/java/com/ge/predix/controller/test/ConfigureEnvironment.java/*view*/ ).
If tests pass, feel free to merge this in.