Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nmahadevuni
Copy link
Member

Description

This change adds a Apache DataSketches CPP package to the setup scripts

Motivation and Context

This package is required to implement Theta sketch aggregate and scalar functions required for Iceberg statistics. The functions will be implemented in a different PR #25685 .

Impact

No impact

Test Plan

== NO RELEASE NOTE ==

@nmahadevuni nmahadevuni requested review from a team as code owners December 19, 2025 11:17
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 19, 2025
@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and Joe-Abraham and removed request for a team December 19, 2025 11:17
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 19, 2025

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nmahadevuni nmahadevuni requested a review from czentgr December 19, 2025 11:17
Copy link
Contributor

@Joe-Abraham Joe-Abraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @nmahadevuni

@Joe-Abraham Joe-Abraham changed the title [native] Add dependency on Apache DataSketches CPP for Sketch Theta functions build(native): Add dependency on Apache DataSketches CPP for Sketch Theta functions Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants