Thanks to visit codestin.com
Credit goes to github.com

Skip to content

do not error for missing external file links #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prjemian merged 10 commits into from
Nov 1, 2021
Merged

do not error for missing external file links #147

prjemian merged 10 commits into from
Nov 1, 2021

Conversation

@prjemian
Copy link
Owner

@prjemian prjemian commented Oct 30, 2021

@prjemian prjemian added the bug label Oct 30, 2021
@prjemian prjemian added this to the v1.0.0 release milestone Oct 30, 2021
@prjemian prjemian requested a review from carterbox October 30, 2021 18:18
@prjemian prjemian self-assigned this Oct 30, 2021
@prjemian
Copy link
Owner Author

prjemian commented Oct 30, 2021

@carterbox This is ready for your review, if you have the time. All unit tests are now in-source. The tests here involve missing external file links and also a soft link within a file to an HDF5 address that has a missing external link. The latter is replicated since the original data file is >60MB.

@prjemian prjemian mentioned this pull request Nov 1, 2021
Closed
carterbox
carterbox requested changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of this PR is that previously missing external links in HDF5 files were mishandled somehow and caused an exception? With this patch, there is now no exception, and the tree report states that the link is broken.

I think the test descriptions could be a bit more helpful. Otherwise, I ran the tests on my local machine and they all pass.

@prjemian prjemian requested a review from carterbox November 1, 2021 22:48
@prjemian
Copy link
Owner Author

prjemian commented Nov 1, 2021

@carterbox : If you approve, can you push the big green button? Thanks!

@prjemian prjemian merged commit e0b4f83 into main Nov 1, 2021
@prjemian prjemian deleted the 130-parse-bug branch November 1, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carterbox carterbox carterbox approved these changes

Assignees

@prjemian prjemian

Labels

bug

Projects

None yet

Milestone

v1.0.0-release

Development

Successfully merging this pull request may close these issues.

BUG: tree cannot parse some NeXus examples

3 participants

@prjemian @carterbox