Keep record of unwinded containers on page refresh#581
Keep record of unwinded containers on page refresh#581beorn7 merged 3 commits intoprometheus:masterfrom
Conversation
The solution retains a record of the currently un-collapsed container and unwinds it on a page refresh. No extra refresh button and no live-update. The minor inconvenience of this solution is that on a page refresh the unwind animation plays. Helps prometheus#568 Signed-off-by: Julien Midedji <[email protected]>
|
@beorn7 would you have a look? |
|
On my list. |
|
I think this is quite good for a start. But maybe we should use the session storage rather than the local storage? A user might open different windows with different views on the same PGW. Also, it might confusing if you come back to the PGW UI after some time and get elements expanded because they are still persisted in your local storage. You might also get garbage left behind, maybe even leading to multiple elements getting expanded on reload. |
Signed-off-by: Julien Midedji <[email protected]>
|
You're right, I replaced it with |
beorn7
left a comment
There was a problem hiding this comment.
Thank you. I think this will work as intended.
However, you need to run make assets and commit the results to bake the changes into the Go binary.
Signed-off-by: Julien Midedji <[email protected]>
Alright, done. Thanks, I appreciate the guidance and your time in reviewing this 🙂 |
The solution retains a record of the currently un-collapsed container and unwinds it on a page refresh.
No extra refresh button and no live-update.
The minor inconvenience of this solution is that on a page refresh the unwind animation plays.
Screencast.from.2023-10-02.18-40-31.webm
Helps #568