Move unhandled rejection listener to cli scripts #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction * origin/master: chore: Move index.js into lib/ (#338)
bkeepers
added a commit
that referenced
this pull request
Nov 21, 2017
* origin/master: fix: Move unhandled rejection listener to cli scripts (#339) chore: Move index.js into lib/ (#338) Add option to develop Probot on Glitch (#306) refactor: absorb github-app chore: Setup Appveyor (#334) docs: Replace examples with include from website (#327) # Conflicts: # lib/index.js
bkeepers
added a commit
that referenced
this pull request
Nov 21, 2017
* origin/master: fix: Move unhandled rejection listener to cli scripts (#339) chore: Move index.js into lib/ (#338) Add option to develop Probot on Glitch (#306) refactor: absorb github-app chore: Setup Appveyor (#334) docs: Replace examples with include from website (#327) # Conflicts: # lib/index.js
bkeepers
added a commit
that referenced
this pull request
Nov 24, 2017
* origin/master: Fix two 404s to the API docs (#344) Add `context.log` to add event context to each log message (#321) fix(package): update github to version 12.0.3 (#340) chore(packaging): Remove semantic-release from CI (#341) refactor: switch ejs for hbs fix: Move unhandled rejection listener to cli scripts (#339) chore: Move index.js into lib/ (#338) Add option to develop Probot on Glitch (#306) refactor: absorb github-app chore: Setup Appveyor (#334) docs: Replace examples with include from website (#327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests that
require('probot')withjest --watch, you'll eventually get:To reproduce it, save the following in a file and run it with
jest --watch. Hit enter 10 times to re-run the test, and you should see the warning above appear.This has to do with the way jest reloads code. This PR moves the registering of the
unhandledRejectionrejection listener to thesetupmethod, which is called by the CLI scripts.