Deprecating stateful helpers with stateless helpers #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Mar 27, 2023
- Deprecating chip_client_clusters, chip_cluster_commands, chip_cluster_responses and chip_cluster_command_arguments with all_user_clusters, zcl_commands, zcl_command_responses and zcl_command_arguments respectively
- Adding more attributes to the command in db-mapping along with the extension to the zcl_command query
- Updating selectAllClustersDetailsFromEndpointTypes such that all_user_clusters can be filtered based on side of cluster
- Adding zcl_command_responses to retrieve all commands which are also command responses.a
- Github: ZAP#971
bzbarsky-apple
approved these changes
Mar 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
- Coverage 66.88% 66.84% -0.05%
==========================================
Files 156 156
Lines 16952 16970 +18
Branches 3683 3687 +4
==========================================
+ Hits 11339 11344 +5
- Misses 5613 5626 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- Deprecating chip_client_clusters, chip_cluster_commands, chip_cluster_responses and chip_cluster_command_arguments with all_user_clusters, zcl_commands, zcl_command_responses and zcl_command_arguments respectively - Adding more attributes to the command in db-mapping along with the extension to the zcl_command query - Updating selectAllClustersDetailsFromEndpointTypes such that all_user_clusters can be filtered based on side of cluster - Adding zcl_command_responses to retrieve all commands which are also command responses.a - Extending asJavaType to handle asJavaBoxedType properly under all block helpers and not just chipType block helpers - Updating the local map for command query - Minor cleanup - Github: ZAP#971
39e45b1 to
1962c3e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.