Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding struct item helper based on struct and cluster name #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Adding struct item helper based on struct and cluster name #1002

merged 1 commit into from
Apr 21, 2023

Conversation

@brdandu
Copy link
Collaborator

@brdandu brdandu commented Apr 20, 2023

  • Add zcl_struct_items_by_struct_and_cluster_name helper for retrieving struct items based on struct and cluster name in helper-zcl.js
  • Updating selectAllStructItemsByStructName to handle cluster name as well
  • Updating the xml for TargetStruct such that it is now present in binding and access control clusters
  • Adding a test to make sure the right struct items are generated based on cluster names
  • Github: ZAP#916

@brdandu brdandu linked an issue Apr 20, 2023 that may be closed by this pull request
Having two identically-named structs can end up failing Matter test codegen #916
Closed
bzbarsky-apple
bzbarsky-apple approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brdandu
Adding struct item helper based on struct and cluster name
ef16b4b 
- Add zcl_struct_items_by_struct_and_cluster_name helper for retrieving struct items based on struct and cluster name in helper-zcl.js
- Updating selectAllStructItemsByStructName to handle cluster name as well
- Updating the xml for TargetStruct such that it is now present in binding and access control clusters
- Adding a test to make sure the right struct items are generated based on cluster names
- Github: ZAP#916
@brdandu brdandu force-pushed the feature/helperForStructItemsBasedOnStructAndClusterName/ZAP#916 branch from 565a4ea to ef16b4b Compare April 21, 2023 13:22
@brdandu brdandu merged commit 01d8e00 into project-chip:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tecimovic tecimovic Awaiting requested review from tecimovic tecimovic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Having two identically-named structs can end up failing Matter test codegen

2 participants

@brdandu @bzbarsky-apple