Fix provisional handling for Darwin to be consistent. #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
approved these changes
Oct 27, 2023
paulr34
approved these changes
Oct 27, 2023
woody-apple
approved these changes
Oct 27, 2023
We treated things with neither "introduced" nor "provisional" annotations as provisional in availabilityHelper(), but isProvisional() returned false for them. This could lead us to generate non-provisional code (conditioned on isProvisional()) that would try to call into things with provisional availability, which would fail to compile. The fix is to make isProvisional the source of truth for whether things are provisional, move the "no introduced annotation" check into isProvisional, and factor out the "have provisional annotation" logic so we can keep having the warning when we take the "provisional because not otherwise annotated" codepath.
c49a77f to
1a1325f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treated things with neither "introduced" nor "provisional" annotations as provisional in availabilityHelper(), but isProvisional() returned false for them. This could lead us to generate non-provisional code (conditioned on isProvisional()) that would try to call into things with provisional availability, which would fail to compile.
The fix is to make isProvisional the source of truth for whether things are provisional, move the "no introduced annotation" check into isProvisional, and factor out the "have provisional annotation" logic so we can keep having the warning when we take the "provisional because not otherwise annotated" codepath.