Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure endpoint is deleted before creating a new one in "Delete and Add" #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

Ensure endpoint is deleted before creating a new one in "Delete and Add" #1661

merged 1 commit into from
Oct 23, 2025

Conversation

@dhchandw
Copy link
Collaborator

@dhchandw dhchandw commented Oct 23, 2025

No description provided.

@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 23, 2025

Summary of Changes

Hello @dhchandw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential race condition in the endpoint management logic by ensuring that a new endpoint is only created after the previous one has been successfully deleted. This change enhances the reliability of the "Delete and Add" functionality and improves error reporting for deletion failures, making the application more robust.

Highlights

  • Asynchronous Operation Sequencing: The deleteAndAddDeviceType method now correctly sequences the deletion and creation of endpoints by awaiting the successful completion of the deletion before initiating the creation, preventing potential race conditions.
  • Improved Error Handling: The deleteEpt method has been updated to return a promise and throw a more descriptive error message upon failure, enhancing error visibility and debugging for endpoint deletion issues.
  • Version Update: The project version in package.json has been incremented from "0.0.0" to "2025.10.23".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 23, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a race condition in the "Delete and Add" functionality by ensuring the endpoint deletion promise resolves before creating a new endpoint. The error handling is also improved by propagating errors up the promise chain. I have one suggestion to further improve the user experience by adding a visual notification on failure, instead of only logging to the console.

@dhchandw dhchandw merged commit 1d6778b into project-chip:master Oct 23, 2025
14 checks passed
@dhchandw dhchandw deleted the cleanup/delAndAdd branch October 23, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brdandu brdandu brdandu approved these changes

@paulr34 paulr34 paulr34 approved these changes

@tecimovic tecimovic Awaiting requested review from tecimovic tecimovic is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhchandw @brdandu @paulr34