[Ember] Fix endpoint bitmask initialization. Fix EmberAfEndpointOptions bitmap values. #38168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns bitmap values.
andy31415
reviewed
Mar 28, 2025
andy31415
reviewed
Mar 28, 2025
|
PR #38168: Size comparison from 97ffa50 to 5187fdf Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38168: Size comparison from 97ffa50 to 472db3d Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38168: Size comparison from 1560a87 to 6324275 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38168: Size comparison from a44fbcf to ecdbdeb Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Mar 31, 2025
|
PR #38168: Size comparison from a44fbcf to 4378f05 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38168: Size comparison from 3cc17d5 to ed82fd2 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Mar 31, 2025
|
PR #38168: Size comparison from 3cc17d5 to 0ba624b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38168: Size comparison from 542888b to be1a5e4 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Apr 2, 2025
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #38168: Size comparison from 542888b to 374cd22 Full report (3 builds for cc32xx, stm32)
|
|
PR #38168: Size comparison from c6da026 to ccdba6d Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
soares-sergio
pushed a commit
to soares-sergio/connectedhomeip
that referenced
this pull request
Apr 8, 2025
…ns bitmap values. (project-chip#38168) * [Ember] Fix endpoint bitmask initialization. Fix EmberAfEndpointOptions bitmap values. * Remove isTree. Only use isFlat to determine compositon. * + * Fix breaking build. * Fix breaking build. * Restyled by clang-format * apply review suggestion * IsTreeCompositionForEndpoint: Return false for invalid endpoints * BridgedNode is also full-family. Add documentation * Update src/app/util/attribute-storage.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/util/attribute-storage.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
…ns bitmap values. (project-chip#38168) * [Ember] Fix endpoint bitmask initialization. Fix EmberAfEndpointOptions bitmap values. * Remove isTree. Only use isFlat to determine compositon. * + * Fix breaking build. * Fix breaking build. * Restyled by clang-format * apply review suggestion * IsTreeCompositionForEndpoint: Return false for invalid endpoints * BridgedNode is also full-family. Add documentation * Update src/app/util/attribute-storage.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/util/attribute-storage.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -
0x02(isFlatComposition) is a subset of0x03(isTreeComposition). The fix is to discard0x03and use onlyisFlatCompositionto determine composition - flat (true) or tree (false).Testing
Tested with oven device from PR: #38108
src/python_testing/TC_DeviceBasicComposition.py on oven device.
Testing