Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release-1.20: Cherrypicks for v1.20.2 #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunjayBhatia merged 2 commits into from
Jun 14, 2022
Merged

release-1.20: Cherrypicks for v1.20.2 #4576

sunjayBhatia merged 2 commits into from
Jun 14, 2022

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Jun 13, 2022

sunjayBhatia and others added 2 commits June 13, 2022 23:06
@sunjayBhatia
internal/dag: Fix private key validation logic (projectcontour#4544)
9e1b9b7 
Make sure we don't return early on parsing a valid PKCS1 RSA or PKCS8
key

Signed-off-by: Sunjay Bhatia <[email protected]>
@skriss @jerome-quere @sunjayBhatia
internal/dag: don't log error for non-CA opaque secrets (projectconto…
c289e92 
…ur#4528)

Fixes a bug where Contour would log an error
for every Opaque secret that didn't contain a 
ca.crt key. Now an error is logged only when a
ca.crt key is present AND its value is not a valid
PEM certificate list.

Signed-off-by: Jérôme Quéré <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
Co-authored-by: Jérôme Quéré <[email protected]>
Co-authored-by: Steve Kriss <[email protected]>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner June 13, 2022 23:09
@sunjayBhatia sunjayBhatia requested review from skriss and stevesloka and removed request for a team June 13, 2022 23:09
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #4576 (cfe05a8) into release-1.20 (550b8ae) will increase coverage by 0.08%.
The diff coverage is 66.66%.

❗ Current head cfe05a8 differs from pull request most recent head c289e92. Consider uploading reports for the commit c289e92 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.20    #4576      +/-   ##
================================================
+ Coverage         77.81%   77.90%   +0.08%     
================================================
  Files               112      112              
  Lines             10027    10030       +3     
================================================
+ Hits               7803     7814      +11     
+ Misses             2042     2035       -7     
+ Partials            182      181       -1
Impacted Files Coverage Δ
internal/dag/secret.go 77.35% <66.66%> (+8.42%) ⬆️

@sunjayBhatia sunjayBhatia merged commit 4d95a2c into projectcontour:release-1.20 Jun 14, 2022
@sunjayBhatia sunjayBhatia deleted the 1.20.2-cherrypicks branch June 14, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunjayBhatia @skriss