internal/provisioner: Unify the ensure objects deleted #4630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Liu <[email protected]>
Signed-off-by: Gang Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4630 +/- ##
==========================================
+ Coverage 75.96% 76.09% +0.12%
==========================================
Files 140 140
Lines 13103 13073 -30
==========================================
- Hits 9954 9948 -6
+ Misses 2892 2870 -22
+ Partials 257 255 -2
|
skriss
requested changes
Jul 29, 2022
skriss
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are so many EnsureXDeleted in the sub-packages of objects , so unify them to EnsureObjectDelete to let maintain work easy
Signed-off-by: Gang Liu [email protected]