Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@skriss
Copy link
Member

@skriss skriss commented Jul 27, 2022

Updates the "upgrade from" version logic for when
on a tag to get the correct previous tag.

Signed-off-by: Steve Kriss [email protected]

@skriss skriss requested a review from a team as a code owner July 27, 2022 18:33
@skriss skriss requested review from stevesloka and tsaarni and removed request for a team July 27, 2022 18:33
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jul 27, 2022
@skriss skriss requested a review from sunjayBhatia July 27, 2022 18:34
@skriss
Copy link
Member Author

skriss commented Jul 27, 2022

The upgrade tests for the build of the v1.22.0 tag failed, they were trying to upgrade from v1.22.0 to v1.22.0 which is not right, so this updates the logic to pull e.g. v1.21.1 when on the v1.22.0 tag.

ref. https://github.com/projectcontour/contour/runs/7545776606?check_suite_focus=true

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #4646 (ff9d566) into main (28444c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4646   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         140      140           
  Lines       13103    13103           
=======================================
  Hits         9954     9954           
  Misses       2892     2892           
  Partials      257      257           

Updates the "upgrade from" version logic for when
on a tag to get the correct previous tag.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss force-pushed the pr-fix-upgrade-from-version-for-tags branch from e05b98c to 32307a6 Compare July 28, 2022 18:09
Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss merged commit 9758a49 into projectcontour:main Jul 28, 2022
@skriss skriss deleted the pr-fix-upgrade-from-version-for-tags branch July 29, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants