Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Gateway YAML generation for extracted namespace file #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skriss merged 2 commits into from
Sep 13, 2022
Merged

Update Gateway YAML generation for extracted namespace file #4720

skriss merged 2 commits into from
Sep 13, 2022

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Sep 13, 2022 •
edited by skriss
Loading

Closes #4519.

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Sep 13, 2022
@sunjayBhatia sunjayBhatia marked this pull request as ready for review September 13, 2022 19:56
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner September 13, 2022 19:56
@sunjayBhatia sunjayBhatia requested review from skriss and stevesloka and removed request for a team September 13, 2022 19:56
@sunjayBhatia sunjayBhatia mentioned this pull request Sep 13, 2022
Merged
skriss
skriss approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #4720 (1cece63) into main (7a60071) will not change coverage.
The diff coverage is n/a.

❗ Current head 1cece63 differs from pull request most recent head 88612a6. Consider uploading reports for the commit 88612a6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4720   +/-   ##
=======================================
  Coverage   76.08%   76.08%           
=======================================
  Files         140      140           
  Lines       13073    13073           
=======================================
  Hits         9946     9946           
  Misses       2873     2873           
  Partials      254      254

@skriss
Copy link
Member

skriss commented Sep 13, 2022

Filed #4721 to look at simplifying some of this code.

@skriss
Copy link
Member

skriss commented Sep 13, 2022

Looks like needs to be added to https://github.com/projectcontour/contour/blob/main/test/scripts/make-kind-cluster.sh#L122-L126 as well.

@sunjayBhatia
kind setup
88612a6 
Signed-off-by: Sunjay Bhatia <[email protected]>
@skriss
Copy link
Member

skriss commented Sep 13, 2022

I'm going to merge as-is with the test flake/timeout since this passed most of the upgrade/E2E matrix runs.

@skriss skriss merged commit 9466ab1 into projectcontour:main Sep 13, 2022
@sunjayBhatia sunjayBhatia deleted the regen-gw-crds branch September 14, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deploying Gateway Provisioner with kustomize fails with accumulation error

2 participants

@sunjayBhatia @skriss