-
Notifications
You must be signed in to change notification settings - Fork 703
Dependency updates for release-1.22 #4882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates for release-1.22 #4882
Conversation
Bump go, golang.org/x/net+text, github.com/emicklei/go-restful manually Signed-off-by: Sunjay Bhatia <[email protected]>
|
flake downloading kustomize, will re-run |
|
Does it make sense to bump ginkgo/gomega here like you did for release-1.23? |
yeah we could def do that, though the thought was to be a little more conservative on the older releases since the version changes in those tools was broader/to avoid debugging something unrelated |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.22 #4882 +/- ##
=============================================
Coverage 75.96% 75.96%
=============================================
Files 140 140
Lines 13102 13102
=============================================
Hits 9953 9953
Misses 2892 2892
Partials 257 257 |
Fair enough. I see there's no explicit version override for |
yeah the x/net bump makes the x/text bump a no-op |
skriss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, upgrade test failures looked like probably flakes to me
Bump go, golang.org/x/net+text, github.com/emicklei/go-restful manually