Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sunjayBhatia
Copy link
Member

Bump go, golang.org/x/net+text, github.com/emicklei/go-restful manually

Bump go, golang.org/x/net+text, github.com/emicklei/go-restful manually

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 30, 2022
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner November 30, 2022 16:19
@sunjayBhatia sunjayBhatia requested review from skriss and tsaarni and removed request for a team November 30, 2022 16:19
@sunjayBhatia
Copy link
Member Author

flake downloading kustomize, will re-run

@skriss
Copy link
Member

skriss commented Nov 30, 2022

Does it make sense to bump ginkgo/gomega here like you did for release-1.23?

@sunjayBhatia
Copy link
Member Author

Does it make sense to bump ginkgo/gomega here like you did for release-1.23?

yeah we could def do that, though the thought was to be a little more conservative on the older releases since the version changes in those tools was broader/to avoid debugging something unrelated

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #4882 (d4a663e) into release-1.22 (a34c6d5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-1.22    #4882   +/-   ##
=============================================
  Coverage         75.96%   75.96%           
=============================================
  Files               140      140           
  Lines             13102    13102           
=============================================
  Hits               9953     9953           
  Misses             2892     2892           
  Partials            257      257           

@skriss
Copy link
Member

skriss commented Nov 30, 2022

Does it make sense to bump ginkgo/gomega here like you did for release-1.23?

yeah we could def do that, though the thought was to be a little more conservative on the older releases since the version changes in those tools was broader/to avoid debugging something unrelated

Fair enough. I see there's no explicit version override for golang.org/x/net so that must be getting bumped as a result of one of the other ones?

@sunjayBhatia
Copy link
Member Author

Does it make sense to bump ginkgo/gomega here like you did for release-1.23?

yeah we could def do that, though the thought was to be a little more conservative on the older releases since the version changes in those tools was broader/to avoid debugging something unrelated

Fair enough. I see there's no explicit version override for golang.org/x/net so that must be getting bumped as a result of one of the other ones?

yeah the x/net bump makes the x/text bump a no-op

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, upgrade test failures looked like probably flakes to me

@sunjayBhatia sunjayBhatia merged commit ca7dc19 into projectcontour:release-1.22 Nov 30, 2022
@sunjayBhatia sunjayBhatia deleted the 1.22-dep-updates branch November 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants