Thanks to visit codestin.com
Credit goes to github.com

Skip to content

internal/k8s: Updates to KindOf helper #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skriss merged 1 commit into from
Feb 28, 2023
Merged

internal/k8s: Updates to KindOf helper #5012

skriss merged 1 commit into from
Feb 28, 2023

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Jan 26, 2023

Adds support for kinds that were missing

Relevant to #5011 and to work on #5007

For now a draft while we think about how to not have to manage this manually

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #5012 (5ee727e) into main (cc1cb8c) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

❗ Current head 5ee727e differs from pull request most recent head 122418d. Consider uploading reports for the commit 122418d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5012      +/-   ##
==========================================
- Coverage   78.01%   77.46%   -0.55%     
==========================================
  Files         138      138              
  Lines       17604    16900     -704     
==========================================
- Hits        13733    13092     -641     
+ Misses       3600     3553      -47     
+ Partials      271      255      -16
Impacted Files Coverage Δ
internal/k8s/kind.go 61.40% <100.00%> (+0.61%) ⬆️
internal/gatewayapi/helpers.go 84.95% <0.00%> (-2.99%) ⬇️
internal/dag/conditions.go 94.03% <0.00%> (-2.14%) ⬇️
internal/envoy/v3/route.go 75.83% <0.00%> (-1.52%) ⬇️
cmd/contour/cli.go 3.94% <0.00%> (-0.69%) ⬇️
internal/sorter/sorter.go 98.97% <0.00%> (-0.33%) ⬇️
internal/dag/httpproxy_processor.go 92.35% <0.00%> (-0.22%) ⬇️
internal/dag/cache.go 94.26% <0.00%> (-0.11%) ⬇️
internal/featuretests/v3/envoy.go 98.97% <0.00%> (-0.04%) ⬇️
... and 13 more

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2023
@skriss skriss mentioned this pull request Feb 22, 2023
Merged
@skriss
Copy link
Member

skriss commented Feb 22, 2023

Need to add Namespace as well.

Let's get this merged, then can revisit if there's a refactor we can do here to avoid having to manually maintain this.

@skriss skriss removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2023
@sunjayBhatia sunjayBhatia marked this pull request as ready for review February 27, 2023 20:19
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner February 27, 2023 20:19
@sunjayBhatia sunjayBhatia requested review from skriss, stevesloka and tsaarni and removed request for a team February 27, 2023 20:19
skriss
skriss approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this'll probably conflict with #5114 so will hold this one until after that merges.

@skriss
Copy link
Member

skriss commented Feb 28, 2023

Now ready for rebase

@sunjayBhatia
internal/k8s: Updates to KindOf helper
122418d 
Adds support for kinds that were missing

Signed-off-by: Sunjay Bhatia <[email protected]>
@skriss skriss merged commit fea8d13 into projectcontour:main Feb 28, 2023
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
@sunjayBhatia @vmw-yingy
internal/k8s: Updates to KindOf helper (projectcontour#5012)
048f87b 
Adds support for kinds that were missing

Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunjayBhatia @skriss