test/e2e: Fix wait for Envoy Deployment update #5048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failures in main daily build showed we were not checking the right status/etc. fields for Envoy in Deployment mode. Now mimic DaemonSet check, since we can have runs where there is no Contour image container in the Deployment pods. Signed-off-by: Sunjay Bhatia <[email protected]>
806eae8 to
571db64
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5048 +/- ##
=======================================
Coverage 77.48% 77.49%
=======================================
Files 138 138
Lines 16904 16904
=======================================
+ Hits 13098 13099 +1
+ Misses 3551 3550 -1
Partials 255 255
|
skriss
approved these changes
Feb 6, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Failures in main daily build showed we were not checking the right status/etc. fields for Envoy in Deployment mode. Now mimic DaemonSet check, since we can have runs where there is no Contour image container in the Deployment pods. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Failures in main daily build showed we were not checking the right status/etc. fields for Envoy in Deployment mode. Now mimic DaemonSet check, since we can have runs where there is no Contour image container in the Deployment pods. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
Failures in main daily build showed we were not checking the right status/etc. fields for Envoy in Deployment mode. Now mimic DaemonSet check, since we can have runs where there is no Contour image container in the Deployment pods. Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures in main daily build showed we were not checking the right status/etc. fields for Envoy in Deployment mode.
Now mimic DaemonSet check, since we can have runs where there is no Contour image container in the Deployment pods.