-
Notifications
You must be signed in to change notification settings - Fork 703
Bump Go to 1.20.0 #5049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump Go to 1.20.0 #5049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See release notes: https://go.dev/doc/go1.20 Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
skriss
approved these changes
Feb 6, 2023
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
tsaarni
reviewed
Feb 13, 2023
Signed-off-by: Sunjay Bhatia <[email protected]>
Also stop linting tools package for now Signed-off-by: Sunjay Bhatia <[email protected]>
tsaarni
approved these changes
Feb 13, 2023
Member
tsaarni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5049 +/- ##
==========================================
+ Coverage 77.86% 77.96% +0.10%
==========================================
Files 138 137 -1
Lines 17259 17233 -26
==========================================
- Hits 13438 13436 -2
+ Misses 3562 3538 -24
Partials 259 259
|
Signed-off-by: Sunjay Bhatia <[email protected]>
skriss
approved these changes
Feb 13, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
See release notes: https://go.dev/doc/go1.20 Removes usage of rand.Seed. Also stops linting tools package for now. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
See release notes: https://go.dev/doc/go1.20 Removes usage of rand.Seed. Also stops linting tools package for now. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
See release notes: https://go.dev/doc/go1.20 Removes usage of rand.Seed. Also stops linting tools package for now. Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See release notes: https://go.dev/doc/go1.20