Fix the upgrade e2e test flakiness #5041
Merged
+51
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
reviewed
Feb 1, 2023
sunjayBhatia
reviewed
Feb 1, 2023
sunjayBhatia
reviewed
Feb 1, 2023
7c20179 to
d1a2b42
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5041 +/- ##
=======================================
Coverage 77.49% 77.49%
=======================================
Files 138 138
Lines 16904 16904
=======================================
Hits 13099 13099
Misses 3550 3550
Partials 255 255 |
8847532 to
068acd5
Compare
skriss
reviewed
Feb 2, 2023
skriss
reviewed
Feb 2, 2023
The upgrade e2e test can fail in some situations because the envoy waiter is incorrectly returning true before the StatefulSet even manages to finish the rollout since it only checks the StatefulSet state on properties that are inconsistently populated due to timing differences. This fix addressed that by using a similar condition validation method as the one already used for the Contour Deployment rollout. Signed-off-by: Aurel Canciu <[email protected]>
068acd5 to
9bc5296
Compare
skriss
approved these changes
Feb 2, 2023
Member
skriss
left a comment
There was a problem hiding this comment.
LGTM, will leave for @sunjayBhatia. Thanks @relu!
sunjayBhatia
approved these changes
Feb 3, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
The upgrade e2e test can fail in some situations because the envoy waiter is incorrectly returning true before the StatefulSet even manages to finish the rollout since it only checks the StatefulSet state on properties that are inconsistently populated due to timing differences. This fix addressed that by using a similar condition validation method as the one already used for the Contour Deployment rollout. Signed-off-by: Aurel Canciu <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
The upgrade e2e test can fail in some situations because the envoy waiter is incorrectly returning true before the StatefulSet even manages to finish the rollout since it only checks the StatefulSet state on properties that are inconsistently populated due to timing differences. This fix addressed that by using a similar condition validation method as the one already used for the Contour Deployment rollout. Signed-off-by: Aurel Canciu <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
The upgrade e2e test can fail in some situations because the envoy waiter is incorrectly returning true before the StatefulSet even manages to finish the rollout since it only checks the StatefulSet state on properties that are inconsistently populated due to timing differences. This fix addressed that by using a similar condition validation method as the one already used for the Contour Deployment rollout. Signed-off-by: Aurel Canciu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade e2e test can fail in some situations because the envoy waiter is incorrectly returning true before the StatefulSet even manages to finish the rollout since it only checks the StatefulSet state on properties that are inconsistently populated due to timing differences.
This fix addressed that by using a similar condition validation method as the one already used for the Contour Deployment rollout.