Gateway API: clean up conditions and filter processing #5125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces custom condition types/reasons with upstream ones, and cleans up filter processing for consistency. Closes projectcontour#5103. Signed-off-by: Steve Kriss <[email protected]>
0bc03dd to
f468cfb
Compare
Signed-off-by: Steve Kriss <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5125 +/- ##
==========================================
- Coverage 78.02% 77.98% -0.04%
==========================================
Files 138 138
Lines 17517 17510 -7
==========================================
- Hits 13668 13656 -12
- Misses 3583 3588 +5
Partials 266 266
|
sunjayBhatia
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces custom condition types/reasons with
upstream ones, and cleans up filter processing
for consistency.
Closes #5103.
Signed-off-by: Steve Kriss [email protected]