Thanks to visit codestin.com
Credit goes to github.com

Skip to content

internal/dag: finish the TODO for EnsureService #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skriss merged 2 commits into from
Mar 22, 2023
Merged

internal/dag: finish the TODO for EnsureService #5155

skriss merged 2 commits into from
Mar 22, 2023

Conversation

@izturn
Copy link
Member

@izturn izturn commented Mar 9, 2023

Signed-off-by: Gang Liu [email protected]

@izturn
reactor 'EnsureService'
7fd98c4 
Signed-off-by: Gang Liu <[email protected]>
@izturn izturn requested a review from a team as a code owner March 9, 2023 05:39
@izturn izturn requested review from stevesloka and tsaarni and removed request for a team March 9, 2023 05:39
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited
Loading

Codecov Report

Merging #5155 (ca7d3be) into main (8df6e89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5155   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         138      138           
  Lines       17731    17736    +5     
=======================================
+ Hits        13820    13825    +5     
  Misses       3646     3646           
  Partials      265      265
Impacted Files Coverage Δ
internal/dag/accessors.go 98.50% <100.00%> (ø)
internal/dag/gatewayapi_processor.go 94.91% <100.00%> (ø)
internal/dag/httpproxy_processor.go 92.67% <100.00%> (ø)
internal/dag/ingress_processor.go 97.07% <100.00%> (+0.07%) ⬆️

skriss
skriss reviewed Mar 9, 2023
View reviewed changes
@izturn izturn requested a review from skriss March 10, 2023 02:25
@izturn
handle error & merge
ca7d3be 
Signed-off-by: Gang Liu <[email protected]>
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Mar 22, 2023
@skriss skriss merged commit 749f06d into projectcontour:main Mar 22, 2023
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Mar 27, 2023
@izturn @yangyy93
internal/dag: refactor EnsureService (projectcontour#5155)
49f4a87 
Refactors EnsureService to take port numbers
instead of IntOrStrings, to simplify the common
case.

Signed-off-by: Gang Liu <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Mar 27, 2023
@izturn @yangyy93
internal/dag: refactor EnsureService (projectcontour#5155)
04974e9 
Refactors EnsureService to take port numbers
instead of IntOrStrings, to simplify the common
case.

Signed-off-by: Gang Liu <[email protected]>
Signed-off-by: yy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@izturn @skriss