Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTTPProxy: support Host header rewrites per-service #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunjayBhatia merged 4 commits into from
Mar 22, 2023
Merged

HTTPProxy: support Host header rewrites per-service #5195

sunjayBhatia merged 4 commits into from
Mar 22, 2023

Conversation

@fangfpeng
Copy link
Contributor

@fangfpeng fangfpeng commented Mar 17, 2023 •
edited by skriss
Loading

Closes #4002

@fangfpeng fangfpeng requested a review from a team as a code owner March 17, 2023 16:14
@fangfpeng fangfpeng requested review from skriss and tsaarni and removed request for a team March 17, 2023 16:14
@skriss
Copy link
Member

skriss commented Mar 17, 2023 •
edited
Loading

The code change LGTM, I don't think anything further is needed - just need to finalize tests.

Can also drop this line now: https://github.com/projectcontour/contour/blob/main/apis/projectcontour/v1/httpproxy.go#L885

(will need to run make generate afterwards)

@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Mar 17, 2023
@fangfpeng
Add more test cases
7654207 
Also add a yaml example for host header rewrite
on both route and service level.

Signed-off-by: Fang Peng <[email protected]>
skriss
skriss reviewed Mar 20, 2023
View reviewed changes
skriss
skriss reviewed Mar 20, 2023
View reviewed changes
@fangfpeng
Move new tests to TestHeadersPolicy
6a59556 
Also add missing comma

Signed-off-by: Fang Peng <[email protected]>
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Merging #5195 (0ba13ff) into main (9890fe9) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5195      +/-   ##
==========================================
- Coverage   78.02%   77.92%   -0.10%     
==========================================
  Files         138      138              
  Lines       17545    17742     +197     
==========================================
+ Hits        13690    13826     +136     
- Misses       3591     3650      +59     
- Partials      264      266       +2
Impacted Files Coverage Δ
internal/dag/httpproxy_processor.go 92.27% <100.00%> (-0.30%) ⬇️
internal/dag/ingress_processor.go 97.00% <100.00%> (ø)
internal/dag/policy.go 95.78% <100.00%> (+0.03%) ⬆️
internal/envoy/route.go 78.72% <100.00%> (+0.46%) ⬆️
internal/envoy/v3/route.go 78.37% <100.00%> (+1.03%) ⬆️

... and 5 files with indirect coverage changes

@fangfpeng
Add Changelog
0ba13ff 
Signed-off-by: Fang Peng <[email protected]>
@skriss skriss requested a review from sunjayBhatia March 21, 2023 14:46
skriss
skriss approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fangfpeng!

@sunjayBhatia sunjayBhatia merged commit 5cbd2f0 into projectcontour:main Mar 22, 2023
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Mar 27, 2023
@fangfpeng @yangyy93
HTTPProxy: support Host header rewrites per-service (projectcontour#5195
be405b2 
)

Closes projectcontour#4002

Signed-off-by: Fang Peng <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Mar 27, 2023
@fangfpeng @yangyy93
HTTPProxy: support Host header rewrites per-service (projectcontour#5195
479a818 
)

Closes projectcontour#4002

Signed-off-by: Fang Peng <[email protected]>
Signed-off-by: yy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/small A small change that needs one line of explanation in the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support Host header rewrites per-service

3 participants

@fangfpeng @skriss @sunjayBhatia