internal/envoy/v3: Trim trailing slashes from path separated prefix match #5217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 138 138
Lines 17757 17759 +2
=======================================
+ Hits 13826 13828 +2
Misses 3663 3663
Partials 268 268
|
…atch Found when testing out kubernetes-sigs/gateway-api#1855 We could also do this higher up in dag processing but this seems like the common/failsafe option. Signed-off-by: Sunjay Bhatia <[email protected]>
0aa23a5 to
025251b
Compare
skriss
reviewed
Mar 23, 2023
Signed-off-by: Sunjay Bhatia <[email protected]>
skriss
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when testing out
kubernetes-sigs/gateway-api#1855
We could also do this higher up in dag processing but this seems like the common/failsafe option.