test/e2e: clone DefaultTransport and disable keep-alives #5210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5210 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 138 138
Lines 17731 17731
=======================================
Hits 13820 13820
Misses 3646 3646
Partials 265 265 |
Signed-off-by: Steve Kriss <[email protected]>
sunjayBhatia
approved these changes
Mar 20, 2023
This was referenced Mar 20, 2023
skriss
added a commit
to skriss/contour
that referenced
this pull request
Mar 21, 2023
…& admin Repeats the change from projectcontour#5210 for requests to the metrics and admin listeners. Signed-off-by: Steve Kriss <[email protected]>
skriss
added a commit
to skriss/contour
that referenced
this pull request
Mar 21, 2023
Repeats the change from projectcontour#5210 for requests to the metrics and admin listeners. Signed-off-by: Steve Kriss <[email protected]>
skriss
added a commit
that referenced
this pull request
Mar 21, 2023
…& admin (#5212) Repeats the change from #5210 for requests to the metrics and admin listeners. Signed-off-by: Steve Kriss <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
…our#5210) * test/e2e: clone DefaultTransport for HTTP requests * disable keep alives Signed-off-by: Steve Kriss <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
…& admin (projectcontour#5212) Repeats the change from projectcontour#5210 for requests to the metrics and admin listeners. Signed-off-by: Steve Kriss <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
These flakes appear to have been resolved by projectcontour#5210 and projectcontour#5212, so the retries are no longer needed. Closes projectcontour#4536. Closes projectcontour#4246. Closes projectcontour#4229. Signed-off-by: Steve Kriss <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
…our#5210) * test/e2e: clone DefaultTransport for HTTP requests * disable keep alives Signed-off-by: Steve Kriss <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
…& admin (projectcontour#5212) Repeats the change from projectcontour#5210 for requests to the metrics and admin listeners. Signed-off-by: Steve Kriss <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Mar 27, 2023
These flakes appear to have been resolved by projectcontour#5210 and projectcontour#5212, so the retries are no longer needed. Closes projectcontour#4536. Closes projectcontour#4246. Closes projectcontour#4229. Signed-off-by: Steve Kriss <[email protected]> Signed-off-by: yy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.