Gateway API: support regex path and header match #5239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support regex path and regex header match for HTTPRoute. - support regex header match for GRPCRoute. Fixes projectcontour#3357 Fixes projectcontour#5219 Signed-off-by: Fang Peng <[email protected]>
Signed-off-by: Fang Peng <[email protected]>
Signed-off-by: Fang Peng <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5239 +/- ##
==========================================
+ Coverage 77.85% 77.90% +0.05%
==========================================
Files 138 138
Lines 17759 17856 +97
==========================================
+ Hits 13826 13911 +85
- Misses 3665 3675 +10
- Partials 268 270 +2
|
skriss
requested changes
Apr 7, 2023
Member
skriss
left a comment
There was a problem hiding this comment.
Thanks for this @fangfpeng! Couple comments
Signed-off-by: Fang Peng <[email protected]>
skriss
requested changes
Apr 7, 2023
Signed-off-by: Fang Peng <[email protected]>
skriss
approved these changes
Apr 10, 2023
Member
skriss
left a comment
There was a problem hiding this comment.
Thanks for the updates @fangfpeng, LGTM!
Signed-off-by: Fang Peng <[email protected]>
sunjayBhatia
approved these changes
Apr 11, 2023
padlar
pushed a commit
to padlar/contour
that referenced
this pull request
Apr 20, 2023
* Gateway API: support regex path and header match - support regex path and regex header match for HTTPRoute. - support regex header match for GRPCRoute. Fixes projectcontour#3357 Fixes projectcontour#5219 Signed-off-by: Fang Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3357
Fixes #5219