Migrate Service and Ingress to client-go dynamic client #2373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
=========================================
- Coverage 77.97% 77.8% -0.18%
=========================================
Files 61 61
Lines 5236 5248 +12
=========================================
Hits 4083 4083
- Misses 1066 1076 +10
- Partials 87 89 +2
Continue to review full report at Codecov.
|
jpeach
approved these changes
Mar 23, 2020
Contributor
jpeach
left a comment
There was a problem hiding this comment.
Looks good, just a couple of tweaks.
Would you mind taking the comment you added to the PR and including that in the commit message?
74de18f to
97f55a1
Compare
This is further refactoring for projectcontour#2219. Moves Service and Ingress to the client-go dynamic client, leaving only Secrets and Endpoints not handled by the new InformerSet. Secrets need namespace handling, and Endpoints need a separate handler. Signed-off-by: Nick Young <[email protected]>
97f55a1 to
f9a74b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is further refactoring for #2219.
Moves Service and Ingress to the client-go dynamic client, leaving only Secrets and Endpoints not handled by the new InformerSet. Secrets need namespace handling, and Endpoints need a separate handler.
Signed-off-by: Nick Young [email protected]