site: documentation for TLS client authentication #2390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
- Coverage 77.46% 77.42% -0.04%
==========================================
Files 64 64
Lines 5422 5422
==========================================
- Hits 4200 4198 -2
- Misses 1132 1133 +1
- Partials 90 91 +1
Continue to review full report at Codecov.
|
jpeach
suggested changes
Mar 30, 2020
Contributor
jpeach
left a comment
There was a problem hiding this comment.
Other than the couple of nits, this looks good to me. When the API lands, we can apply this change to "site/docs/master/httpproxy.md"
6397496 to
38e4a16
Compare
Member
Author
|
Thanks for reviewing! Sorry, somehow I managed to miss that that there is "site/docs/master/" for development of docs. I've now moved my change there :) |
jpeach
suggested changes
Apr 1, 2020
Contributor
jpeach
left a comment
There was a problem hiding this comment.
Looks good, one last editorial nit.
Added documentation describing the external client certificate validation. Signed-off-by: Tero Saarni <[email protected]>
38e4a16 to
5a24d04
Compare
jpeach
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation describing the external client certificate validation.
Signed-off-by: Tero Saarni [email protected]