cmd/contour: Add flag to specify status.loadbalancer address statically #2421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2421 +/- ##
==========================================
- Coverage 76.69% 76.67% -0.02%
==========================================
Files 68 68
Lines 5489 5506 +17
==========================================
+ Hits 4210 4222 +12
- Misses 1182 1187 +5
Partials 97 97
Continue to review full report at Codecov.
|
jpeach
left a comment
There was a problem hiding this comment.
Good change! We should add a test, but everything else is optional nits.
| ServiceName: ctx.envoyServiceName, | ||
| LBStatus: lbsw.lbStatus, | ||
| // step 12. register an informer to watch envoy's service if we haven't been given static details. | ||
| if ctx.ingressStatusAddress == "" { |
There was a problem hiding this comment.
Do we care if the address passed in is valid? Like if I entered steve.s.%%% for the address. Maybe a followup issue, but just thinking out loud.
There was a problem hiding this comment.
We could check that it's either a DNS name or IP address, I suppose.
There was a problem hiding this comment.
Actually, I've thought over this more, and I don't think it's worth doing much validation here. We already check if it's an IP or a hostname, I think that's enough.
63a1f7c to
5d757a5
Compare
5d757a5 to
76868c4
Compare
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour. Setting this flag will disable the automatic Envoy service watching for those details. Fixes projectcontour#2387 Updates projectcontour#403 Further documentation to come under projectcontour#403. Signed-off-by: Nick Young <[email protected]>
76868c4 to
1893a3a
Compare
jpeach
left a comment
There was a problem hiding this comment.
LGTM. I'm OK with not doing any additional validity checks on the hostname status address.
Adds the
--ingress-status-addressflag to specify what address should be added to Ingressstatus.loadbalancerstanza by Contour.Setting this flag will disable the automatic Envoy service watching for those details.
Fixes #2387
Updates #403
Further documentation to come under #403.
Signed-off-by: Nick Young [email protected]