Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Apr 15, 2020

Since files move around in the repository and it's hard to keep the glob
patterns for misspell up to date, just use git ls-files to find all
the markdown and html in the repository and check everything.

This updates #2130.

Signed-off-by: James Peach [email protected]

Since files move around in the repository and it's hard to keep the glob
patterns for misspell up to date, just use `git ls-files` to find all
the markdown and html in the repository and check everything.

This updates projectcontour#2130.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach requested a review from stevesloka April 15, 2020 04:22
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #2439 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
- Coverage   76.83%   76.79%   -0.04%     
==========================================
  Files          68       68              
  Lines        5512     5512              
==========================================
- Hits         4235     4233       -2     
- Misses       1181     1182       +1     
- Partials       96       97       +1     
Impacted Files Coverage Δ
internal/dag/cache.go 95.25% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2828b8e...dc3c2b1. Read the comment docs.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice.

@jpeach jpeach merged commit 877add2 into projectcontour:master Apr 16, 2020
@jpeach jpeach deleted the list-misspell-dirs branch April 16, 2020 04:43
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants