cmd/contour: remove hard-coded default log fields #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default JSON log fields are specified in `envoy.DefaultFields`. We don't need to keep a copy of that list in the configuration defaults because `(*ListenerVisitorConfig) accesslogFields()` will correctly handle populating the default fields. Signed-off-by: James Peach <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2446 +/- ##
==========================================
- Coverage 76.79% 76.69% -0.10%
==========================================
Files 68 68
Lines 5512 5489 -23
==========================================
- Hits 4233 4210 -23
Misses 1182 1182
Partials 97 97
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default JSON log fields are specified in
envoy.DefaultFields. Wedon't need to keep a copy of that list in the configuration defaults
because
(*ListenerVisitorConfig) accesslogFields()will correctlyhandle populating the default fields.
Signed-off-by: James Peach [email protected]