Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Apr 21, 2020

Add a GitHub workflow to run the repository label sync tooling for the
"projectcontour" org. This runs when the labels YAML changes and every
hour in the meantime.

Signed-off-by: James Peach [email protected]

@jpeach jpeach requested review from stevesloka and youngnick April 21, 2020 02:48
Add a GitHub workflow to run the repository label sync tooling for the
"projectcontour" org. This runs when the labels YAML changes and every
hour in the meantime.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach force-pushed the label-sync-workflow branch from cff933a to abc2fc2 Compare April 21, 2020 02:49
@jpeach jpeach changed the title Enable GitHuib workflow to run label sync. Enable GitHub workflow to run label sync. Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #2452 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
+ Coverage   76.71%   76.75%   +0.03%     
==========================================
  Files          68       68              
  Lines        5515     5515              
==========================================
+ Hits         4231     4233       +2     
+ Misses       1187     1186       -1     
+ Partials       97       96       -1     
Impacted Files Coverage Δ
internal/dag/cache.go 95.98% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f71eb9...abc2fc2. Read the comment docs.

@stevesloka
Copy link
Member

@jpeach you tested this on a fork right?

@jpeach
Copy link
Contributor Author

jpeach commented Apr 27, 2020

@jpeach you tested this on a fork right?

Yup I tested it in a personal repo.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fingers crossed.

@youngnick
Copy link
Member

But, @stevesloka should probably approve as well.

@jpeach jpeach merged commit 90004f1 into projectcontour:master Apr 30, 2020
@jpeach jpeach deleted the label-sync-workflow branch April 30, 2020 01:03
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants