Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@youngnick
Copy link
Member

Signed-off-by: Nick Young [email protected]

@youngnick youngnick self-assigned this Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #2470 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2470   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files          68       68           
  Lines        5522     5522           
=======================================
  Hits         4237     4237           
  Misses       1188     1188           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234b034...c62fa42. Read the comment docs.

@youngnick youngnick force-pushed the 1.4-release-blog branch 3 times, most recently from 27ba546 to 365d896 Compare April 27, 2020 00:39
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stevesloka
Copy link
Member

A couple of nit errors in the site proofing step of the CI job that failed.

Copy link
Contributor

@jonasrosland jonasrosland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change requested, and I'll follow up with another PR to fix the community footer with the correct meeting dates/times.

@youngnick youngnick force-pushed the 1.4-release-blog branch 3 times, most recently from 86824c9 to a2d1769 Compare April 28, 2020 00:13
Signed-off-by: Nick Young <[email protected]>
@youngnick
Copy link
Member Author

The two links that are showing as broken in one of the builds are the ones for this blog post, and the one for my tag, which has no blogs in it until this is published.

@youngnick youngnick requested a review from jonasrosland April 28, 2020 00:37
@youngnick
Copy link
Member Author

@jonasrosland All done from what I can see. Feel free to merge this and promote.

@jonasrosland jonasrosland merged commit f7bce9a into projectcontour:master Apr 28, 2020
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants