cmd/contour: support comma-separated ingress-status-address #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
+ Coverage 76.97% 77.07% +0.09%
==========================================
Files 68 70 +2
Lines 5707 5736 +29
==========================================
+ Hits 4393 4421 +28
- Misses 1218 1219 +1
Partials 96 96
|
jpeach
suggested changes
May 20, 2020
Contributor
jpeach
left a comment
There was a problem hiding this comment.
Great PR @al45tair; good commit message and test coverage, very nice!
Just one minor review comment where I think we can simplify separating the comma-separated addresses.
The CI failure is complaining about goimports formatting problem. You can verify this locally by running make lint. It looks like goimports wants to align the field values of your test cases.
When using a cluster without a LoadBalancer, it's common to configure Envoy to use host networking and to run on some number of nodes (maybe all of them, using a DaemonSet). In that case, Contour won't pick up the IP addresses automatically as there's no LoadBalancer; one approach to working around this is to supply the --ingress-status-address argument, but this only supported a single address. This changeset adds support for multiple addresses, separated by commas. Fixes projectcontour#2540 Signed-off-by: Alastair Houghton <[email protected]>
jpeach
approved these changes
May 20, 2020
Contributor
jpeach
left a comment
There was a problem hiding this comment.
This LGTM. I'll give @youngnick a chance to review before I merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a cluster without a LoadBalancer, it's common to configure
Envoy to use host networking and to run on some number of nodes (maybe
all of them, using a DaemonSet).
In that case, Contour won't pick up the IP addresses automatically as
there's no LoadBalancer; one approach to working around this is to
supply the --ingress-status-address argument, but this only supported
a single address.
This changeset adds support for multiple addresses, separated by
commas.
Fixes #2540
Signed-off-by: Alastair Houghton [email protected]