Fix site proofing on master builds #2627
Merged
+19
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
=======================================
Coverage 76.78% 76.78%
=======================================
Files 71 71
Lines 5540 5540
=======================================
Hits 4254 4254
Misses 1199 1199
Partials 87 87 |
stevesloka
approved these changes
Jun 25, 2020
Member
stevesloka
left a comment
There was a problem hiding this comment.
/lgtm
We should probably just make the links to k8s use a variable or something. But even that could get out of date as things upstream change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2624
Due to #2031 the updated job won't run for this PR, but you can see a passing build on my fork here.
For now, I opted to update the broken links in the old versioned docs. We can decide down the road to exclude those subdirs from the site proofing job if they continue to create more issues that we don't want to fix.
The haproxy.org link appears to be unresponsive when requested from Travis workers - even a simple curl times out - so I added it to the excludes list for the proofer.