Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stevesloka
Copy link
Member

When running make checkall, the tasklint-yamllint required docker. For users not wanting to keep docker running locally, this change allows to run the same command from a binary without a docker container.

Signed-off-by: Steve Sloka [email protected]

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files          71       71           
  Lines        5540     5540           
=======================================
  Hits         4254     4254           
  Misses       1199     1199           
  Partials       87       87           

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngnick youngnick merged commit 1f0e003 into projectcontour:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants