hack: remove unused boilerplate copyright file #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2654 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 71 71
Lines 5591 5591
=======================================
Hits 4301 4301
Misses 1203 1203
Partials 87 87 |
skriss
approved these changes
Jul 6, 2020
Member
skriss
left a comment
There was a problem hiding this comment.
Looks like DCO is missing, but LGTM once that's added.
The file `boilerplate.go.tmpl` in the `hack` directory is used to add the copyright information to the top of each generated file. This file is no longer used since now the same information is added inline to the `hack/generate-crd-deepcopy.sh` script. Signed-off-by: Steve Sloka <[email protected]>
c9b7d39 to
1d4591f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
boilerplate.go.tmplin thehackdirectory is used to add the copyright informationto the top of each generated file. This file is no longer used since now the same information is
added inline to the
hack/generate-crd-deepcopy.shscript.