Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stevesloka
Copy link
Member

@stevesloka stevesloka commented Jul 6, 2020

apis/contour: remove contour v1beta1 api
site: remove references to IngressRoute

Removes the contour/v1beta1 apis as well as further references from the docs on IngressRoute.

Updates #2572

@stevesloka stevesloka requested review from jpeach, skriss and youngnick July 6, 2020 17:15
@stevesloka stevesloka force-pushed the removeIngressRouteAPI branch 2 times, most recently from e0d3967 to 941583e Compare July 8, 2020 19:58
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2655 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2655      +/-   ##
==========================================
+ Coverage   76.96%   77.00%   +0.03%     
==========================================
  Files          71       71              
  Lines        5653     5653              
==========================================
+ Hits         4351     4353       +2     
+ Misses       1211     1210       -1     
+ Partials       91       90       -1     
Impacted Files Coverage Δ
internal/dag/cache.go 99.04% <0.00%> (+0.95%) ⬆️

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, but they don't block this. Nice work @stevesloka, LGTM.

site: remove references to IngressRoute

Removes the contour/v1beta1 apis as well as further references from the docs on IngressRoute.

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka force-pushed the removeIngressRouteAPI branch from 941583e to 6849a02 Compare July 14, 2020 15:04
@stevesloka stevesloka merged commit f095a6b into projectcontour:master Jul 14, 2020
@stevesloka stevesloka deleted the removeIngressRouteAPI branch July 14, 2020 15:15
@skriss skriss mentioned this pull request Jul 14, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants