Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@skriss
Copy link
Member

@skriss skriss commented Jul 7, 2020

Signed-off-by: Steve Kriss [email protected]

updates #2225

@skriss skriss added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 7, 2020
@skriss skriss requested review from jpeach, stevesloka and youngnick July 7, 2020 17:32
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2661 into master will increase coverage by 0.03%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
+ Coverage   76.93%   76.96%   +0.03%     
==========================================
  Files          71       71              
  Lines        5605     5618      +13     
==========================================
+ Hits         4312     4324      +12     
- Misses       1205     1206       +1     
  Partials       88       88              
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)
internal/contour/listener.go 92.00% <71.42%> (-0.75%) ⬇️
cmd/contour/servecontext.go 93.49% <100.00%> (+0.05%) ⬆️
internal/envoy/listener.go 97.64% <100.00%> (+0.03%) ⬆️
internal/dag/cache.go 99.04% <0.00%> (+0.95%) ⬆️

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skriss skriss merged commit a5b6c47 into projectcontour:master Jul 8, 2020
@skriss skriss deleted the add-stream-idle-timeout branch July 8, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants