apis/projectcontour: rename the HTTPProxy Status type #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f6a01c to
54209d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2689 +/- ##
==========================================
+ Coverage 76.96% 77.00% +0.03%
==========================================
Files 71 71
Lines 5653 5653
==========================================
+ Hits 4351 4353 +2
+ Misses 1211 1210 -1
+ Partials 91 90 -1
|
Member
|
@jpeach just need to commit the generated files back to pass CI. |
Rename the `Status` struct to `HTTPProxyStatus`. This means that the type name won't conflict when we bring new CRDs into the `v1` namespace, and makes the nomenclature consistent with established CRD patterns. This is a no-op for API users, since the field name doesn't change, but is an incompatible source change for projects using the Go types. Signed-off-by: James Peach <[email protected]>
54209d2 to
ab32e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
Statusstruct toHTTPProxyStatus. This means that thetype name won't conflict when we bring new CRDs into the
v1namespace,and makes the nomenclature consistent with established CRD patterns.
This is a no-op for API users, since the field name doesn't change,
but is an incompatible source change for projects using the Go types.
Signed-off-by: James Peach [email protected]